Use iterative traversal for deeply nested constraints#31
Open
1Jul1an wants to merge 1 commit intoUniversal-Variability-Language:mainfrom
Open
Use iterative traversal for deeply nested constraints#311Jul1an wants to merge 1 commit intoUniversal-Variability-Language:mainfrom
1Jul1an wants to merge 1 commit intoUniversal-Variability-Language:mainfrom
Conversation
Member
|
Hi @1Jul1an, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long UVL constraints can create deeply nested parse and constraint trees. The default ANTLR
ParseTreeWalkerand the type-level constraint validation both traversed these structures recursively, which can overflow the Java stack for constraints with thousands of literals.This change introduces an iterative
ParseTreeWalkerand validates type-level constraints with an explicit stack while preserving traversal order.A regression test covers a generated UVL model with 7000 OR-connected literals.
Related to FeatureIDE/FeatureIDE#1458
Tested with:
mvn clean test